Re: [PATCH] drm: mxsfb: Implement drm_panel handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tested-by: Breno Lima <breno.lima@xxxxxxx>




From: Thierry Reding <thierry.reding@xxxxxxxxx>
Sent: Wednesday, February 1, 2017 3:22 PM
To: Fabio Estevam
Cc: airlied@xxxxxxxx; marex@xxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Breno Matheus Lima
Subject: Re: [PATCH] drm: mxsfb: Implement drm_panel handling
 
On Wed, Feb 01, 2017 at 03:19:47PM -0200, Fabio Estevam wrote:
> Currently when the 'power-supply' regulator is passed via device tree
> it does not actually work since drm_panel_prepare()/drm_panel_enable()
> are never called.
>
> Quoting Thierry Reding: "It should really call drm_panel_prepare() and
> drm_panel_enable() while switching on the display pipeline and
> drm_panel_disable(), followed by drm_panel_unprepare() while switching
> off the display pipeline."
>
> So do as suggested, so that the 'power-supply' regulator can be functional.
>
> Reported-by: Breno Lima <breno.lima@xxxxxxx>
> Suggested-by: Thierry Reding <thierry.reding@xxxxxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
>  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux