Re: [PATCH 2/2] drm: Rely on mode_config data for fb_helper initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx> writes:

> Instead of receiving the num_crts as a parameter, we can read it
> directly from the mode_config structure.  I audited the drivers that
> invoke this helper and I believe all of them (but one, see below)
> initialize the mode_config struct accordingly, prior to calling the
> fb_helper.

This is a nice cleanup!  It always felt silly to be passing in my
mode_config's members to the fbdev setup.  Could we do the same for
num_connector?

I've verified that all the drivers either init their CRTCs or have
already looked at mode_config.num_crtcs before the fbdev init call, so
this is:

Reviewed-by: Eric Anholt <eric@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux