On Sat, 28 Jan 2017, Peter Senna Tschudin <peter.senna@xxxxxxxxxxxxx> wrote:
> On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote:
> Hi Archit,
>
> Thank you for the comments!
>
> [...]
>> > + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
>> > + if (total_size > EDID_LENGTH) {
>> > + kfree(block);
>> > + block = kmalloc(total_size, GFP_KERNEL);
>> > + if (!block)
>> > + return NULL;
>> > +
>> > + /* Yes, read the entire buffer, and do not skip the first
>> > + * EDID_LENGTH bytes.
>> > + */
>>
>> Is this the reason why you aren't using drm_do_get_edid()?
>
> Yes, for some hw specific reason, it is necessary to read the entire
> EDID buffer starting from 0, not block by block.
Hrmh, I'm planning on moving the edid override and firmware edid
mechanisms at the drm_do_get_edid() level to be able to truly and
transparently use a different edid. Currently, they're only used for
modes, really, and lead to some info retrieved from overrides, some from
the real edid. This kind of hacks will bypass the override/firmware edid
mechanisms then too. :(
BR,
Jani.
>
> [...]
>
> I fixed all your other suggestions. Thank you!
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
