Re: [PATCH 1/4] drm: qxl: Drop misleading comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 26, 2017 at 11:05:45PM -0200, Gabriel Krisman Bertazi wrote:
> No longer true since commit 07f8d9bdb235 ("drm/qxl: add support for > 1
> output").  qxl_num_crtc defaults to 4 and is configurable as a module
> parameter.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/qxl/qxl_fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
> index e6ade6aab54c..4ba2d2f81bd3 100644
> --- a/drivers/gpu/drm/qxl/qxl_fb.c
> +++ b/drivers/gpu/drm/qxl/qxl_fb.c
> @@ -399,7 +399,7 @@ int qxl_fbdev_init(struct qxl_device *qdev)
>  			      &qxl_fb_helper_funcs);
>  
>  	ret = drm_fb_helper_init(qdev->ddev, &qfbdev->helper,
> -				 qxl_num_crtc /* num_crtc - QXL supports just 1 */,
> +				 qxl_num_crtc,

btw if you're super-bored could do an audit to make sure all drivers init
crtc before calling this function. And then removing this argument and
replacing it with dev->mode_config.num_crtcs.
-Daniel

>  				 QXLFB_CONN_LIMIT);
>  	if (ret)
>  		goto free;
> -- 
> 2.11.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux