On 27 January 2017 at 01:23, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
> On 27 January 2017 at 01:05, Gabriel Krisman Bertazi
> <krisman@xxxxxxxxxxxxxxx> wrote:
>> qxl_device duplicates a pointer to struct device, which is not needed
>> since we already have it in the drm_device structure. Clean it up.
>>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx>
>> ---
>> drivers/gpu/drm/qxl/qxl_drv.h | 1 -
>> drivers/gpu/drm/qxl/qxl_kms.c | 1 -
>> drivers/gpu/drm/qxl/qxl_object.c | 16 ++++++++--------
>> drivers/gpu/drm/qxl/qxl_object.h | 8 ++++----
>> 4 files changed, 12 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
>> index 0d877fa61162..a022de205134 100644
>> --- a/drivers/gpu/drm/qxl/qxl_drv.h
>> +++ b/drivers/gpu/drm/qxl/qxl_drv.h
>> @@ -242,7 +242,6 @@ void qxl_debugfs_remove_files(struct qxl_device *qdev);
>> struct qxl_device;
>>
>> struct qxl_device {
>> - struct device *dev;
>> struct drm_device *ddev;
>> struct pci_dev *pdev;
> You can also drop pdev. It's in the same "boat" as dev.
>
... which you handled with 3/4. Pardon for the noise.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
