On 01/25/2017 03:53 AM, Alex Williamson wrote:
> Per the ABI specification[1], each mdev_supported_types entry should
> have an available_instances, with an "s", not available_instance.
>
> [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
>
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> ---
>
> This should really be fixed before initial release in v4.10
Acked-by: Jike Song <jike.song@xxxxxxxxx>
Thanks for finding this!
--
Thanks,
Jike
>
> drivers/gpu/drm/i915/gvt/kvmgt.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index faaae07..ab1e057 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,
> return NULL;
> }
>
> -static ssize_t available_instance_show(struct kobject *kobj, struct device *dev,
> - char *buf)
> +static ssize_t available_instances_show(struct kobject *kobj,
> + struct device *dev, char *buf)
> {
> struct intel_vgpu_type *type;
> unsigned int num = 0;
> @@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev,
> type->fence);
> }
>
> -static MDEV_TYPE_ATTR_RO(available_instance);
> +static MDEV_TYPE_ATTR_RO(available_instances);
> static MDEV_TYPE_ATTR_RO(device_api);
> static MDEV_TYPE_ATTR_RO(description);
>
> static struct attribute *type_attrs[] = {
> - &mdev_type_attr_available_instance.attr,
> + &mdev_type_attr_available_instances.attr,
> &mdev_type_attr_device_api.attr,
> &mdev_type_attr_description.attr,
> NULL,
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
