Re: [Intel-gfx] [PATCH 06/15] drm/doc: Clarify connector overview

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 25, 2017 at 10:57:17AM -0200, Gustavo Padovan wrote:
> Hi Daniel,
> 
> 2017-01-25 Daniel Vetter <daniel.vetter@xxxxxxxx>:
> 
> > There was a bit of mix-up between initialization and registering.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > ---
> >  drivers/gpu/drm/drm_connector.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> > index dd720d4cb4f7..c75ab242f907 100644
> > --- a/drivers/gpu/drm/drm_connector.c
> > +++ b/drivers/gpu/drm/drm_connector.c
> > @@ -40,11 +40,10 @@
> >   *
> >   * KMS driver must create, initialize, register and attach at a &struct
> >   * drm_connector for each such sink. The instance is created as other KMS
> > - * objects and initialized by setting the following fields.
> > - *
> > - * The connector is then registered with a call to drm_connector_init() with a
> > - * pointer to the connector functions and a connector type, and exposed through
> > - * sysfs with a call to drm_connector_register().
> > + * objects and initialized by setting the following fields. The connector is
> > + * initialized with a call to drm_connector_init() with a pointer to the
> > + * connector functions and a connector type, and then exposed to userspace with
> 
> &drm_connector_funcs

I'm not really clear what you want me to do here ...
-Daniel

> 
> Other than that:
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxx>

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux