On Mon, Jan 23, 2017 at 3:30 AM, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Thu, Jan 19, 2017 at 10:10:21AM -0500, Alex Deucher wrote: >> On Wed, Jan 18, 2017 at 10:34 AM, Jeff Smith <whydoubt@xxxxxxxxx> wrote: >> > Hello all, >> > >> > This code is very raw at this point, but wanted to get this out there >> > for feedback. >> > >> > This uses codepaths very close to those used for HDMI audio support. >> > The driver currently has this disabled, so I needed to re-enable it. >> > Turning stereo 3D on without turning audio on would require a bit of >> > additional condition handling. >> > >> > I suspect there are some non-stereo modes that will break with the >> > code in its current state, such as modes that require double-scan. >> > >> >> Thanks for the patches. We are in the process of transitioning to new >> updated modesetting code (DC), so I would suggest working against that >> rather than the existing code. You can find the latest DC code on the >> branch below. See the display directory in drivers/gpu/drm/amd. >> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-4.9 > > Given that DAL is still a bit away from getting merged I'm not sure it's a > good idea to block new features from outsiders on it landing ... That > means AMD will need to port this, but that's part of the price to pay for > a wholesale rewrite of the display driver. Before this patch set can land, the current display code needs to grow support for proper audio and infoframe support in general which is a fairly major task. Without that, these patches are not particularly useful as they won't work in most cases. In my opinion, time would be better spent working on helping to get DC merged, but I obviously can't tell you how to spend your time. Alex > -Daniel > >> >> Alex >> >> >> > Regards, >> > Jeff >> > >> > >> > Jeff Smith (2): >> > amdgpu: Stereo 3D support requires enabling audio >> > amdgpu: Add stereo 3D support >> > >> > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 15 +++-- >> > drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 27 ++++---- >> > drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 2 +- >> > drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 86 ++++++++++++++++++++++++-- >> > 4 files changed, 106 insertions(+), 24 deletions(-) >> > >> > -- >> > 2.9.3 >> > >> > _______________________________________________ >> > dri-devel mailing list >> > dri-devel@xxxxxxxxxxxxxxxxxxxxx >> > https://lists.freedesktop.org/mailman/listinfo/dri-devel >> _______________________________________________ >> dri-devel mailing list >> dri-devel@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
