On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: > The i2c adapter on DP AUX is purely a software construct. Linking > it to the device node of the parent device is wrong, as it leads to > 2 devices sharing the same device node, which is bad practice, as > well as the i2c trying to populate children of the i2c adapter by > looking at the child device nodes of the parent device. > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> Since this is about dt, I have no idea what it does or why. Needs someone else to look at & merge. -Daniel > --- > drivers/gpu/drm/drm_dp_helper.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 3e6fe82c6d64..f91ade1edbde 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -1020,7 +1020,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) > aux->ddc.class = I2C_CLASS_DDC; > aux->ddc.owner = THIS_MODULE; > aux->ddc.dev.parent = aux->dev; > - aux->ddc.dev.of_node = aux->dev->of_node; > > strlcpy(aux->ddc.name, aux->name ? aux->name : dev_name(aux->dev), > sizeof(aux->ddc.name)); > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
