On Fri, Jan 20, 2017 at 02:13:00PM +0000, Emil Velikov wrote: > On 19 January 2017 at 09:19, Thierry Reding <treding@xxxxxxxxxx> wrote: > > On Wed, Jan 18, 2017 at 02:59:21PM +0100, Neil Armstrong wrote: > >> Add support for Amlogic Meson DRM driver merged for Linux 4.10. > >> > >> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > >> --- > >> tests/util/kms.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Applied, thanks. > > > Was going to say "NACK use Thierry's helpers" but you've beat me to it. > As a Tl;DR: we _really_ want to stop using drmOpen* for anything that's KMS. I think it's still useful to have this helper to iterate over all supported driver because it enables easy testing with just a simple modetest. That said, for (almost) as long as I remember I've been using the -M option to prevent modetest from iterating over the list, which can take fairly long if you've got DRM_DEBUG messages enabled. I'm not sure I understand exactly what you're suggesting by "use Thierry's helpers". modetest and other tests use util_open() internally now. That in turn uses drmOpen(), though we're of course open to change that. Are you suggesting we somehow use drmDevice to locate existing devices? We could implement some heuristic that finds the first device with a primary node, but what if we want to support the -M option? There is currently no way of getting the driver from drmDevice. Maybe that's something we should add anyway. Thierry
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
