Hi John,
Thank you for the patch.
On Monday 16 Jan 2017 16:52:50 John Stultz wrote:
> In chasing down issues with EDID probing, I found some
> duplicated but incomplete logic used to power the chip on and
> off.
>
> This patch refactors the adv7511_power_on/off functions, so
> they can be used for internal needs.
>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>
> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> v4: Move the regcache_sync() call outside the shared
> implementation as we don't want to call it on EDID probing,
> as suggested by Laurent
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 405e460..12f2876
> 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -325,7 +325,7 @@ static void adv7511_set_link_config(struct adv7511
> *adv7511, adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB;
> }
>
> -static void adv7511_power_on(struct adv7511 *adv7511)
> +static void __adv7511_power_on(struct adv7511 *adv7511)
> {
> adv7511->current_edid_segment = -1;
>
> @@ -354,6 +354,11 @@ static void adv7511_power_on(struct adv7511 *adv7511)
> regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER2,
> ADV7511_REG_POWER2_HPD_SRC_MASK,
> ADV7511_REG_POWER2_HPD_SRC_NONE);
> +}
> +
> +static void adv7511_power_on(struct adv7511 *adv7511)
> +{
> + __adv7511_power_on(adv7511);
>
> /*
> * Most of the registers are reset during power down or when HPD is
low.
> @@ -362,21 +367,23 @@ static void adv7511_power_on(struct adv7511 *adv7511)
>
> if (adv7511->type == ADV7533)
> adv7533_dsi_power_on(adv7511);
> -
> adv7511->powered = true;
> }
>
> -static void adv7511_power_off(struct adv7511 *adv7511)
> +static void __adv7511_power_off(struct adv7511 *adv7511)
> {
> /* TODO: setup additional power down modes */
> regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER,
> ADV7511_POWER_POWER_DOWN,
> ADV7511_POWER_POWER_DOWN);
> regcache_mark_dirty(adv7511->regmap);
> +}
>
> +static void adv7511_power_off(struct adv7511 *adv7511)
> +{
> + __adv7511_power_off(adv7511);
> if (adv7511->type == ADV7533)
> adv7533_dsi_power_off(adv7511);
> -
> adv7511->powered = false;
> }
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
