On Mon, Jan 16, 2017 at 02:38:39PM +0000, Emil Velikov wrote: > On 13 January 2017 at 12:11, Mark Kettenis <mark.kettenis@xxxxxxxxx> wrote: > >> From: Thierry Reding <thierry.reding@xxxxxxxxx> > >> Date: Thu, 12 Jan 2017 23:04:27 +0100 > >> > >> Allow DRM/KMS devices hosted on USB to be detected by the drmDevice > >> infrastructure. > >> > >> v2: > >> - make sysfs_uevent_get() more flexible using a format string > >> > >> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxx> > > > > All this sysfs parsing stuff is highly Linux-specific and should > > probably be #ifdef __linux__. Returning -EINVAL on non-Linux > > platforms for usb and host1x should be fine. > > > Nicely spotted. Thierry with the above the series is > Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx> > > Can you land these in the next few days - I would love to have a > libdrm release and use drmGetDevice[s]2 in mesa. Can do. I've thrown in another cleanup patch to reuse the new sysfs_uevent_get() function (now also #ifdef __linux__) for the Linux- specific PCI bus/device info. tests/drmdevice results are identical and valgrind doesn't flag any leaks. I'll send out the series once more just to be sure, but I think it should now be all fine. Thanks, Thierry
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
