Hi Gustavo,
(CC'ing Steven)
On Monday 16 Jan 2017 19:12:58 Gustavo Padovan wrote:
> 2017-01-16 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>:
> > On Monday 16 Jan 2017 18:13:30 Gustavo Padovan wrote:
> >> From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxx>
> >>
> >> Otherwise compilation fails like this:
> >>
> >> In file included from drivers/gpu/drm/armada/armada_trace.h:66:0,
> >>
> >> from drivers/gpu/drm/armada/armada_trace.c:3:
> >> ./include/trace/define_trace.h:88:43: fatal error: ./armada_trace.h: No
> >> such file or directory compilation terminated.
> >>
> >> Signed-off-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxx>
> >
> > How about a Fixes: line ?
>
> Fixes: c8a220c686a5 ("drm/armada: add tracing support")
Thank you.
The approach taken here seems to be shared by a fair number of drivers, so
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
However, you could also set TRACE_INCLUDE_PATH to ../../drivers/gpu/drm/armada
as done by drivers/dma-buf, drivers/ras and drivers/net/fjes. I'm not sure
what's best, but if setting CFLAGS is preferred, I think we should get rid of
TRACE_INCLUDE_PATH.
Steven, any opinion ? To avoid forcing you to dig the original e-mail up, the
proposed fix is
> diff --git a/drivers/gpu/drm/armada/Makefile
> b/drivers/gpu/drm/armada/Makefile
> index a18f156..64c0b45 100644
> --- a/drivers/gpu/drm/armada/Makefile
> +++ b/drivers/gpu/drm/armada/Makefile
> @@ -4,3 +4,5 @@ armada-y += armada_510.o
> armada-$(CONFIG_DEBUG_FS) += armada_debugfs.o
>
> obj-$(CONFIG_DRM_ARMADA) := armada.o
> +
> +CFLAGS_armada_trace.o := -I$(src)
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
