Hi Dan,
On 13 January 2017 at 12:56, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> drivers/gpu/drm/drm_crtc.c:392 drm_mode_getcrtc()
> error: we previously assumed 'crtc->primary->state' could be null (see line 384)
>
> drivers/gpu/drm/drm_crtc.c
> 383
> 384 if (crtc->primary->state && crtc->primary->state->fb)
> ^^^^^^^^^^^^^^^^^^^^
> New check for NULL.
>
> 385 crtc_resp->fb_id = crtc->primary->state->fb->base.id;
> 386 else if (!crtc->primary->state && crtc->primary->fb)
> 387 crtc_resp->fb_id = crtc->primary->fb->base.id;
> 388 else
> 389 crtc_resp->fb_id = 0;
> 390
> 391 if (crtc->state) {
> 392 crtc_resp->x = crtc->primary->state->src_x >> 16;
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Old unchecked dereference. It's possible that non-NULL "crtc->state"
> implies a non-NULL "crtc->primary->state", but I didn't spot the
> relationship immediately.
Thanks for this. I believe this is indeed an invariant; Dan Vetter
could confirm, if he's managed to find internet in Hobart. Assuming
this is the case, what's the best way to communicate this to smatch;
would that be through a BUG_ON or similar?
Cheers,
Daniel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
