2017-01-11 17:59 GMT+01:00 Arnd Bergmann <arnd@xxxxxxxx>: > On Wed, Jan 11, 2017 at 5:36 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: >> On Wed, Jan 11, 2017 at 5:33 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: >>> CONFIG_DRM_VM=y >> >> Does randconfig just set this for fun, despite that it's a hidden >> Kconfig symbol? Should we add a depends !NOMMU to it to make sure it >> never gets enabled when it shouldn't be? >> >> tbh I have no idea how Kconfig works, I'm just really good at breaking it :( > > no, randconfig won't try to set symbols that a user doesn't see. This > is what 'menuconfig' > says enabled it. > > │ Selected by: DRM_NOUVEAU [=n] && HAS_IOMEM [=y] && DRM [=y] && > PCI [=n] && MMU [=n] && (BACKLIGHT_CLASS_DEVICE [=m] || !ACPI) || > DRM_LEGACY [=y] && HAS_IOMEM [=y] && DRM [=y] > > It must be the 'DRM_LEGACY' option that is actually user visible and > that contains > 'select DRM_VM'. We should add "MMU" on DRM_LEGACY and DRM_VM dependencies to be sure that they won't be select without MMU support > > Arnd -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel