> -----Original Message----- > From: Michel Dänzer [mailto:michel@xxxxxxxxxxx] > Sent: Wednesday, January 11, 2017 3:33 AM > To: Daniel Vetter; Grodzovsky, Andrey > Cc: Deucher, Alexander; dri-devel@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] drm/atomic: Add target_vblank support in atomic > helpers (v2) > > On 09/01/17 06:59 PM, Daniel Vetter wrote: > > On Fri, Jan 06, 2017 at 03:39:40PM -0500, Andrey Grodzovsky wrote: > >> Allows usage of the new page_flip_target hook for drivers > >> implementing the atomic path. > >> Provides default atomic helper for the new hook. > >> > >> v2: > >> Update code sharing logic between exsiting and the new flip hooks. > >> Improve kerneldoc. > >> > >> Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky@xxxxxxx> > > > > Looks all reasonable, I think an ack from Alex that the amd side is in > > shape too, and I'll pull this into drm-misc. > > Andrey, is there an updated patch 2 adapted to current patch 1? Other than > that and some questionable indentation of parameters in function > signatures, looks good to me FWIW. We are unable to use the atomic helpers both for page_flip and page_flip_target At their current form mostly due to DRM_MODE_PAGE_FLIP_ASYNC flag rejection they do. I discussed this with Daniel Vetter on IRC and suggested to remove the rejection but he said the precise semantics of atomic async flip is not clear yet and it's better to leave that out for now until there is a userspace asking for it. So I tested it by just hacking the helper to remove the rejection. Until that settled the original change [PATCH 2/2] drm/amd/dal: Switch to page_flip_target hook in DAL Is what we plan to use in DAL Andrey > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
