Re: [PATCH] drm/imx: imx-tve: Remove unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 04, 2017 at 01:44:56PM -0200, Fabio Estevam wrote:
> 'ret' is never used in tve_enable/tve_disable(), so just
> remove it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>

Applied to drm-misc, thx.
-Daniel

> ---
>  drivers/gpu/drm/imx/imx-tve.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
> index 3b602ee..8f8aa4a 100644
> --- a/drivers/gpu/drm/imx/imx-tve.c
> +++ b/drivers/gpu/drm/imx/imx-tve.c
> @@ -150,13 +150,11 @@ __releases(&tve->lock)
>  
>  static void tve_enable(struct imx_tve *tve)
>  {
> -	int ret;
> -
>  	if (!tve->enabled) {
>  		tve->enabled = true;
>  		clk_prepare_enable(tve->clk);
> -		ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
> -					 TVE_EN, TVE_EN);
> +		regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
> +				   TVE_EN, TVE_EN);
>  	}
>  
>  	/* clear interrupt status register */
> @@ -174,12 +172,9 @@ static void tve_enable(struct imx_tve *tve)
>  
>  static void tve_disable(struct imx_tve *tve)
>  {
> -	int ret;
> -
>  	if (tve->enabled) {
>  		tve->enabled = false;
> -		ret = regmap_update_bits(tve->regmap, TVE_COM_CONF_REG,
> -					 TVE_EN, 0);
> +		regmap_update_bits(tve->regmap, TVE_COM_CONF_REG, TVE_EN, 0);
>  		clk_disable_unprepare(tve->clk);
>  	}
>  }
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux