Re: [PATCH] drm/radeon/kms: Shorten buffers in radeon_ddc_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 27 Jun 2011 22:44:42 +0200, Jean Delvare wrote:
> No need for 2-byte buffers, we only send one byte and receive one
> byte.
> 
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Alex Deucher <alexdeucher@xxxxxxxxx>
> ---
>  drivers/gpu/drm/radeon/radeon_i2c.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> --- linux-3.0-rc4.orig/drivers/gpu/drm/radeon/radeon_i2c.c	2011-06-27 15:39:33.000000000 +0200
> +++ linux-3.0-rc4/drivers/gpu/drm/radeon/radeon_i2c.c	2011-06-27 15:40:35.000000000 +0200
> @@ -34,21 +34,20 @@
>   */
>  bool radeon_ddc_probe(struct radeon_connector *radeon_connector)
>  {
> -	u8 out_buf[] = { 0x0, 0x0};
> -	u8 buf[2];
> +	u8 out = 0x0, in;
>  	int ret;
>  	struct i2c_msg msgs[] = {
>  		{
>  			.addr = 0x50,
>  			.flags = 0,
>  			.len = 1,
> -			.buf = out_buf,
> +			.buf = &out,
>  		},
>  		{
>  			.addr = 0x50,
>  			.flags = I2C_M_RD,
>  			.len = 1,
> -			.buf = buf,
> +			.buf = &in,
>  		}
>  	};

Please disregard this patch, it is superseded by a more important
workaround by Thomas Reim.

-- 
Jean Delvare
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux