On Sun, Jan 01, 2017 at 04:20:53PM -0800, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Fix build errors in nouveau driver when CONFIG_LEDS_CLASS=m and > CONFIG_DRM_NOUVEAU=y. > If LEDS_CLASS is enabled, DRM_NOUVEAU is restricted to the same > kconfig value as LEDS_CLASS. > > drivers/built-in.o: In function `nouveau_do_suspend': > nouveau_drm.c:(.text+0x2030b1): undefined reference to `nouveau_led_suspend' > drivers/built-in.o: In function `nouveau_do_resume': > nouveau_drm.c:(.text+0x2034ca): undefined reference to `nouveau_led_resume' > drivers/built-in.o: In function `nouveau_drm_unload': > nouveau_drm.c:(.text+0x203a15): undefined reference to `nouveau_led_fini' > drivers/built-in.o: In function `nouveau_drm_load': > nouveau_drm.c:(.text+0x204423): undefined reference to `nouveau_led_init' > > BTW, this line in Kbuild: > nouveau-$(CONFIG_LEDS_CLASS) += nouveau_led.o > does nothing when CONFIG_LEDS_CLASS=m and CONFIG_DRM_NOUVEAU=y. > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx> > Cc: Martin Peres <martin.peres@xxxxxxx> > Cc: Ben Skeggs <bskeggs@xxxxxxxxxx> Thrown into drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/nouveau/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- lnx-410-rc2.orig/drivers/gpu/drm/nouveau/Kconfig > +++ lnx-410-rc2/drivers/gpu/drm/nouveau/Kconfig > @@ -1,6 +1,7 @@ > config DRM_NOUVEAU > tristate "Nouveau (NVIDIA) cards" > depends on DRM && PCI > + depends on LEDS_CLASS || LEDS_CLASS=n > select FW_LOADER > select DRM_KMS_HELPER > select DRM_TTM > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
