Re: [PATCH v2 05/13] drm: panels: Constify device node argument to of_drm_find_panel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thierry,

Could you please review this patch ? Should it be merged through you ?

On Saturday 19 Nov 2016 05:28:05 Laurent Pinchart wrote:
> The argument is never modified by the function, make it const.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_panel.c | 2 +-
>  include/drm/drm_panel.h     | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
> index 3dfe3c886502..308d442a531b 100644
> --- a/drivers/gpu/drm/drm_panel.c
> +++ b/drivers/gpu/drm/drm_panel.c
> @@ -137,7 +137,7 @@ EXPORT_SYMBOL(drm_panel_detach);
>   * Return: A pointer to the panel registered for the specified device tree
>   * node or NULL if no panel matching the device tree node can be found.
>   */
> -struct drm_panel *of_drm_find_panel(struct device_node *np)
> +struct drm_panel *of_drm_find_panel(const struct device_node *np)
>  {
>  	struct drm_panel *panel;
> 
> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> index 220d1e2b3db1..4b76cf2d5a7b 100644
> --- a/include/drm/drm_panel.h
> +++ b/include/drm/drm_panel.h
> @@ -193,9 +193,9 @@ int drm_panel_attach(struct drm_panel *panel, struct
> drm_connector *connector); int drm_panel_detach(struct drm_panel *panel);
> 
>  #ifdef CONFIG_OF
> -struct drm_panel *of_drm_find_panel(struct device_node *np);
> +struct drm_panel *of_drm_find_panel(const struct device_node *np);
>  #else
> -static inline struct drm_panel *of_drm_find_panel(struct device_node *np)
> +static inline struct drm_panel *of_drm_find_panel(const struct device_node
> *np) {
>  	return NULL;
>  }

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux