On Thu, 15 Dec 2016, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> Hi Ville,
>
> Thank you for the patch.
>
> On Thursday 15 Dec 2016 16:29:27 ville.syrjala@xxxxxxxxxxxxxxx wrote:
>> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>>
>> Apparently my arm .config had reverted to CMA=n at some point, so I
>> failed to notice that I typoed the code. Fix it up so that the
>> cma helper will compile again.
>>
>> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>> Fixes: ca984a998ad3 ("drm/fb_cma_helper: Replace drm_format_info() with
>> fb->format")
>> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> The kbuild test bot caught this pretty fast, but it was too late as the patch
> was already in a stable branch of a shared tree. Don't you have a git tree
> covered by the bot that you could push patches to during development ?
It was a randconfig result, so even that doesn't guarantee everything is
caught.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
>> b/drivers/gpu/drm/drm_fb_cma_helper.c index aab4465307ed..591f30ebc42a
>> 100644
>> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
>> @@ -309,7 +309,7 @@ static void drm_fb_cma_describe(struct drm_framebuffer
>> *fb, struct seq_file *m) seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width,
>> fb->height,
>> (char *)&fb->format->format);
>>
>> - for (i = 0; i < fb->fomat->num_planes; i++) {
>> + for (i = 0; i < fb->format->num_planes; i++) {
>> seq_printf(m, " %d: offset=%d pitch=%d, obj: ",
>> i, fb->offsets[i], fb->pitches[i]);
>> drm_gem_cma_describe(fb_cma->obj[i], m);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
