On Tue, Dec 13, 2016 at 06:57:59PM +0100, Lucas Stach wrote: > Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter: > > fsl is already fully demidlayered in the probe function, but for > > convenience stuck with drm_put_dev. Call the unregister/unref parts > > separately, to make sure this driver works correct. > > > > v2: Rebase. > > > > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > Cc: Stefan Agner <stefan@xxxxxxxx> > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> Ok, applied this one now too, thanks for your review. -Daniel > > > --- > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > index 537ca159ffe5..0b35da73c2b0 100644 > > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c > > @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev) > > { > > struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev); > > > > - drm_put_dev(fsl_dev->drm); > > + drm_dev_unregister(fsl_dev->drm); > > + drm_dev_unref(fsl_dev->drm); > > clk_disable_unprepare(fsl_dev->clk); > > clk_unregister(fsl_dev->pix_clk); > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel