Re: Unchecked memory allocations in Intel driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 04 Jul 2011 11:18:13 -0700
Keith Packard <keithp@xxxxxxxxxx> wrote:

> On Mon, 4 Jul 2011 13:27:51 +0100, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> > Found this going over intel_bios.c and cross comparing it with the
> > Intel/IMG driver intel_bios.c
> > 
> >         temp_mode = kzalloc(sizeof(*temp_mode), GFP_KERNEL);
> 
> This object is about 216 bytes long; would it be reasonable to allocate
> it on the stack? Or is that pushing stack allocations too far?

You'd have to review the rest of the call stack. Its pretty borderline.

Alan
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux