On 13 December 2016 at 15:42, Eric Engestrom <eric.engestrom@xxxxxxxxxx> wrote: > On Tuesday, 2016-12-13 16:16:50 +0200, Jani Nikula wrote: >> On Tue, 13 Dec 2016, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: >> > Just set the rules automatically rather than asking each contributor to >> > update thing locally. >> > >> > Signed-off-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> >> > --- >> > autogen.sh | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git a/autogen.sh b/autogen.sh >> > index c896097..e936f04 100755 >> > --- a/autogen.sh >> > +++ b/autogen.sh >> > @@ -9,6 +9,12 @@ cd "$srcdir" >> > autoreconf --force --verbose --install || exit 1 >> > cd "$ORIGDIR" || exit $? >> > >> > +git config --local --get format.subjectPrefix || >> > + git config --local format.subjectPrefix "PATCH libdrm" >> > + >> > +git config --local --get sendemail.to || >> > + git config --local sendemail.to "dri-devel@xxxxxxxxxxxxxxxxxxxxx" >> > + >> >> So I don't really play with libdrm source much, but can you expect this >> to only be run in a git repo? How about source/distro/tarball releases? > > These will print an error like this and not do anything, so it should be > fine: > error: could not lock config file .git/config: No such file or directory > > These errors should be hidden though, as we don't care about such > failures, and the config reads should also be silenced as they will > print the previously set values. > > With that fixed: > Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx> > Actually we don't ship autogen.sh within the tarball, but regardless. With a simple "2>/dev/null" things seems to be fine ... Thanks Emil P.S. I wonder if we really shouldn't do this for wayland/weston, Xorg, and dozens of others ;-) _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
