2016-12-12 Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>:
> On Mon, Dec 12, 2016 at 05:41:08PM -0200, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>
> >
> > Previously we were returning garbage here, fix it by setting it to -1
> > before the first possible point of failure.
>
> The convention is that on error paths you do not modify user inputs. In
> particular, consider EINTR where the usual pattern (e.g. drmIoctl) is
>
> do {
> err = ioctl(fd, SUBMIT, arg);
> } while (err == -EINTR);
>
> If you modify the in fence before you consume it, you can't recreate it
> after handling the signal.
Right. I didn't know about that convention. So maybe we let it as is. :)
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
