Re: [PATCH libdrm] xf86drm: fix aliasing violation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 12, 2016 at 3:59 PM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
> On 11 December 2016 at 18:03, Grazvydas Ignotas <notasas@xxxxxxxxx> wrote:
>> Just tell the compiler that drm_event will alias the char buffer,
>> so that it has no excuse to warn or generate bad code.
>>
> Afacit this patch [1] from Thierry should correctly address the issue, correct ?

>From what I've read, gcc's "strict aliasing" means that it's illegal
to access the same memory location using pointers of different types,
with only one exception - accessing an object of any type through a
char pointer. What is done here is the opposite - char array is read
as a struct, so according to that it's still wrong.

That said I haven't seen any compiler causing problems in this case,
and Thierry's solution indeed silences the warning, so I guess you can
take his patch if you prefer.

Gražvydas
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux