Re: [PATCH V2] drm/i915: gracefully bail out when init_clock_gating-pointer is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2 Jul 2011 17:55:53 +0200
Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote:

> On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote:
> > On Mon, 20 Jun 2011 19:36:11 +0200
> > Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote:
> > 
> > > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > > functions) introduces an init_clock_gating-pointer. There is one case,
> > > however, where it does not get set, so that caused an OOPS. Change the
> > > code to return -ENODEV in this case and propagate it to the upper
> > > layers.
> > > 
> > > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> > > Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> > > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > > ---
> > 
> > Looks good, thanks Wolfram.
> > 
> > Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> 
> Just wondering: I don't see it in linux-next or the i915-branches I am aware
> of. Forgotten or intentional?

Bounce it over to Keith with the reviewed-by and he'll pick it up.

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux