Function vc4_cl_lookup_bos() does not set the error code when drm_malloc_ab() returns a NULL pointer, and will return 0 (indicates success). This patch fixes the bug, assigning "-ENOMEM" to the return variable ret on the path that memory allocation fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188631 Signed-off-by: Pan Bian <bianpan2016@xxxxxxx> --- drivers/gpu/drm/vc4/vc4_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index 47a095f..2592a94 100644 --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -544,6 +544,7 @@ struct vc4_hang_state { handles = drm_malloc_ab(exec->bo_count, sizeof(uint32_t)); if (!handles) { + ret = -ENOMEM; DRM_ERROR("Failed to allocate incoming GEM handles\n"); goto fail; } -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
