A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Nov 30, 2016 at 12:35:21PM +0000, Atul Raj wrote: > Hi Greg, > > I am so happy to get a mail from you and I am really sorry Greg that I disappointed you. > I will take utmost care in future. > I will send you correct patch in sometime. > for your ques > "Also, why are you including a ton of people who have nothing to do with > usb patches on this one?" > > I got the name of people from get_maintainer.pl When using get_maintainer.pl on this patch it does not include the dri-devel list, so I don't think you used it correctly. > from now I will include only you. > is it ok?? No, do it correctly. > one more thing in another mail you replied to me as > On Wed, Nov 30, 2016 at 11:40:28AM +0000, Atul Raj wrote: > > changes in v2 > > - added braces as suggested. > > Why is this here? > > > > > drivers/usb/core/hub.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > do you disagree with viresh comment of braces??? I disagree that this is a valid changelog comment, please read Documentation/SubmittingPatches for the correct way to do this. Again, if you don't have experience doing this, please work in the drivers/staging/ directory first, not in the "core" kernel. thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel