On Tue, 29 Nov 2016 22:36:50 +0100 Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, Nov 29, 2016 at 11:18:35AM +0100, Jean-Francois Moine wrote: > > This patchset series adds HDMI video support to the Allwinner > > sun8i SoCs which include the display engine 2 (DE2). > > The driver contains the code for the A83T and H3 SoCs, and > > some H3 boards, but it could be used/extended for other SoCs > > (A64, H2, H5) and boards (Banana PIs, Orange PIs). > > Honestly, I'm getting a bit worried by the fact that you ignore > reviews. > > On the important reviews that you got that are to be seen as major > issues that block the inclusion, we have: > - The fact that the HDMI driver is actually just a designware IP, > and while you should use the driver that already exists, you just > duplicated all that code. The DW registers in the A83T and H3 are obfuscated, so, the code in bridge/DW cannot be used as it is. There should be either a translation table or a function to compute the register addresses. More, it is not sure that the bridge/DW code would work with Allwinner's SoCs. It seems that they got some schematics from DesignWare, but, is it really the same hardware? Also, if some changes had to be done in the bridge code, I could not check if this would break or not the other SoCs. Eventually, I went the same way as omap/hdmi5: different driver. > - The fact that you ignored Rob (v6) and I (v5) comment on using OF > graph to model the connection between the display engine and the > TCON. Something that Laurent also pointed out in this version. I simply use the drm function drm_of_component_probe(). If this one is in the DRM core, why should I not use it? If it must not be used, it would be nice to mark it as deprecated and to update the code of the drivers which are using it. > - The fact that you ignored that you needed an HDMI connector node > as a child of the HDMI controller. This has been reported by Rob > (v6) and yet again in this version by Laurent. As I don't know what is a DT 'connector', I cannot go further. I hope Laurent will give me clearer explanations and a real example. > - And finally the fact that we can't have several display engine in > parallel, if needs be. This has happened in the past already on > Allwinner SoCs, so it's definitely something we should consider in > the DT bindings, since we can't break them. IIRC, I proposed my driver before yours, and the DE2 is completely different from the other display engines. What you are telling is "add more code to already complex code and have a big driver for all SoCs in each kernels". I think it should be better to have small modules, each one treating specific hardware, and to let only the needed code in the kernel memory at startup time. > Until those are fixed, I cannot see how this driver can be merged, > unfortunately. No problem. I just wanted to help people by giving the job I did on the boards I have. My boards are working for almost one year, fine enough for I use them as daily desktop computers. I don't want to spend one more year for having my code in the Linux kernel: there are so much other exciting things to do... -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
