Hi Vladimir, On Thu, Nov 24, 2016 at 8:16 PM, Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx> wrote: > By the way while we're discussing DW HDMI bindings specific to iMX, > I would recommend to remove utterly hackish and iMX only "gpr" > property from the example in bindings/display/bridge/dw_hdmi.txt What if we get rid of the "gpr" property completely? --- a/drivers/gpu/drm/imx/dw_hdmi-imx.c +++ b/drivers/gpu/drm/imx/dw_hdmi-imx.c @@ -99,9 +99,8 @@ static const struct dw_hdmi_phy_config imx_phy_config[] = { static int dw_hdmi_imx_parse_dt(struct imx_hdmi *hdmi) { - struct device_node *np = hdmi->dev->of_node; + hdmi->regmap = syscon_regmap_lookup_by_compatible("fsl,imx6q-iomuxc-gpr"); - hdmi->regmap = syscon_regmap_lookup_by_phandle(np, "gpr"); if (IS_ERR(hdmi->regmap)) { dev_err(hdmi->dev, "Unable to get gpr\n"); return PTR_ERR(hdmi->regmap); Then we can remove the gpr from the device tree files. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel