Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 11/24/2016 10:43 AM, Kuninori Morimoto wrote:

Hi Archit, David, and DRM ML

I had heared that Archit is the maintainer of dw-hdmi driver, but am I wrong ??
I'm posting this patch series since half year ago, but no response
from him, and nothing happen (I got review from Russell though).
Is Archit really maintainer ??
OTOH, get_maintainer.pl indicates David is the maintainer ?
What should I do for this patch ??

I'm not the maintainer of the dw-hdmi driver, but I pull in the
changes that go into drm/bridge/

Will pull this.

Thanks,
Archit



Hi Russell

@@ -11,4 +11,11 @@ struct dw_hdmi_audio_data {
 	u8 *eld;
 };

+struct dw_hdmi_i2s_audio_data {
+	struct dw_hdmi *hdmi;
+
+	void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
+	u8 (*read)(struct dw_hdmi *hdmi, int offset);
+};

Another slight concern here is why we need this separate data for i2s -
maybe adding the write/read ops to struct dw_hdmi_audio_data would be
a better thing to do, which would then allow the AHB audio to drop
the .base argument in the future.

I'm not that bothered about this though.  So...

Thank you for your feedback.
Maybe we can merge these in incremental patch if needed ?


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux