On Mon, Nov 21, 2016 at 05:35:20PM +0100, Daniel Vetter wrote:
> I totally butcherd the job on typing the kernel-doc for these, and no
> one realized. Noticed by Russell. Maarten has a more complete approach
> to this confusion, by making it more explicit what the new/old state
> is, instead of this magic switching behaviour.
Thanks for fixing this. I noticed a couple of mistakes while reading
through the patch:
> diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
> index 72478cf82147..e96d662ea572 100644
> --- a/include/drm/drm_modeset_helper_vtables.h
> +++ b/include/drm/drm_modeset_helper_vtables.h
> @@ -999,10 +999,14 @@ struct drm_mode_config_helper_funcs {
> * to implement blocking and nonblocking commits easily. It is not used
> * by the atomic helpers
> *
> - * This hook should first commit the given atomic state to the hardware.
> - * But drivers can add more waiting calls at the start of their
> - * implementation, e.g. to wait for driver-internal request for implicit
> - * syncing, before starting to commit the update to the hardware.
> + * This function is called when the new atomic state has already been
> + * swapped into the various state pointers. The the passed in state therefore contains
"The the". It also goes way over 80 columns.
> + * copies of the old/previous state. This hook should commit the new
> + * state into hardware. Note that the helpers have already waited for
> + * preceedning atomic commits and fences, but drivers can add more
"preceeding"
> + * waiting calls at the start of their implementation, e.g. to wait for
> + * driver-internal request for implicit syncing, before starting to
> + * commit the update to the hardware.
> *
> * After the atomic update is committed to the hardware this hook needs
> * to call drm_atomic_helper_commit_hw_done(). Then wait for the upate
> --
> 2.10.2
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
