Hi, Daniel: On Fri, 2016-11-18 at 11:22 +0800, Daniel Kurtz wrote: > Hi CK, > > On Thu, Nov 17, 2016 at 1:36 PM, CK Hu <ck.hu@xxxxxxxxxxxx> wrote: > > Hi, Jitao: > > > > > > On Wed, 2016-11-16 at 11:20 +0800, Jitao Shi wrote: > >> Tune dsi frame rate by pixel clock, dsi add some extra signal (i.e. > >> Tlpx, Ths-prepare, Ths-zero, Ths-trail,Ths-exit) when enter and exit LP > >> mode, those signals will cause h-time larger than normal and reduce FPS. > >> So need to multiply a coefficient to offset the extra signal's effect. > >> coefficient = ((htotal*bpp/lane_number)+Tlpx+Ths_prep+Ths_zero+ > >> Ths_trail+Ths_exit)/(htotal*bpp/lane_number) > >> > >> Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx> > > > > It looks good to me. > > But this patch conflict with [1] which is one patch of MT2701 series. I > > want to apply MT2701 patches first, so please help to refine this patch > > based on MT2701 patches. > > I don't think the MT2701 DSI patches are quite ready yet (I just > reviewed the one below). > Can we instead land Jitao's small targeted change first, and then > rebase the MT2701 series on top. > > Thanks, > -Dan MT2701 series looks still have some defect to be fixed. Therefore, I would apply this patch first. Thanks for your help. Regards, CK > > > > [1] https://patchwork.kernel.org/patch/9422821/ > > > > Regards, > > CK > > > >> --- > >> Change since v4: > >> - tune the calc comment more clear. > >> - define the phy timings as constants. > >> > >> Chnage since v3: > >> - wrapp the commit msg. > >> - fix alignment of some lines. > >> > >> Change since v2: > >> - move phy timing back to dsi_phy_timconfig. > >> > >> Change since v1: > >> - phy_timing2 and phy_timing3 refer clock cycle time. > >> - define values of LPX HS_PRPR HS_ZERO HS_TRAIL TA_GO TA_SURE TA_GET DA_HS_EXIT. > >> --- > >> > > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
