Hi Ville,
Thank you for the patch.
On Thursday 17 Nov 2016 18:14:29 ville.syrjala@xxxxxxxxxxxxxxx wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Replace uses of fb->depth with fb->format->depth. Less duplicate
> information is a good thing.
>
> @@
> struct drm_framebuffer *fb;
> expression E1, E2;
> @@
> drm_helper_mode_fill_fb_struct(...) {
> ...
> - fb->depth = E1;
> ...
> }
>
> @@
> struct vmw_framebuffer_surface *vfb;
> expression E;
> @@
> - vfb->base.base.depth = E;
>
> @@
> struct vmw_framebuffer_dmabuf *vfb;
> expression E;
> @@
> - vfb->base.base.depth = E;
>
> @@
> struct nouveau_framebuffer *fb;
> @@
> - fb->base.depth
> + fb->base.format->depth
>
> @@
> struct drm_framebuffer fb;
> expression E;
> @@
> - fb.depth
> + fb.format->depth
>
> @@
> struct drm_framebuffer *fb;
> expression E;
> @@
> - fb->depth
> + fb->format->depth
>
> @@
> struct drm_framebuffer fb;
> @@
> - (fb.format->depth)
> + fb.format->depth
>
> @@
> struct drm_framebuffer *fb;
> @@
> - (fb->format->depth)
> + fb->format->depth
>
> @@
> @@
> struct drm_framebuffer {
> ...
> - unsigned int depth;
> ...
> };
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 4 ++--
> drivers/gpu/drm/armada/armada_fbdev.c | 3 ++-
> drivers/gpu/drm/ast/ast_fb.c | 2 +-
> drivers/gpu/drm/bochs/bochs_fbdev.c | 2 +-
> drivers/gpu/drm/cirrus/cirrus_fbdev.c | 4 ++--
> drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> drivers/gpu/drm/drm_fb_helper.c | 2 +-
> drivers/gpu/drm/drm_framebuffer.c | 2 +-
> drivers/gpu/drm/drm_modeset_helper.c | 2 --
> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +-
> drivers/gpu/drm/gma500/accel_2d.c | 2 +-
> drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> drivers/gpu/drm/gma500/gma_display.c | 2 +-
> drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 +-
> drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 +-
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
> drivers/gpu/drm/mgag200/mgag200_fb.c | 2 +-
> drivers/gpu/drm/mgag200/mgag200_mode.c | 6 +++---
> drivers/gpu/drm/msm/msm_fbdev.c | 2 +-
> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 12 ++++++------
> drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 ++-
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +-
> drivers/gpu/drm/qxl/qxl_fb.c | 5 +++--
> drivers/gpu/drm/radeon/radeon_fb.c | 4 ++--
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 5 +++--
> drivers/gpu/drm/tegra/drm.c | 3 ++-
> drivers/gpu/drm/tegra/fb.c | 2 +-
> drivers/gpu/drm/udl/udl_fb.c | 2 +-
> drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 7 ++++---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 --
> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 5 +++--
> drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 +-
> include/drm/drm_framebuffer.h | 6 ------
> 36 files changed, 56 insertions(+), 59 deletions(-)
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
