On 17 Nov. 2016 8:41 pm, "Arnd Bergmann" <arnd@xxxxxxxx> wrote:
>
> On Thursday, November 17, 2016 4:14:44 AM CET Build bot for Mark Brown wrote:
> > arm64-allmodconfig
> > ../drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:126:36: error: 'OD_CFG' undeclared (first use in this function)
> > ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:220:5: error: 'struct drm_device' has no member named 'vblank_disable_allowed'
> >
> > arm-allmodconfig
> > ../drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:126:36: error: 'OD_CFG' undeclared (first use in this function)
> > ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:220:5: error: 'struct drm_device' has no member named 'vblank_disable_allowed'
>
> These two patches need to be reverted or fixed:
>
> f752fff ("drm/mediatek: set vblank_disable_allowed to true")
> 83ba62b ("drm/mediatek: fix a typo of OD_CFG to OD_RELAYMODE")
>
> Both of them seem to work fine on linux-next, but were accidentally sent
> to Linus yesterday through:
>
> Merge tag 'drm-fixes-for-v4.9-rc6' of git://people.freedesktop.org/~airlied/linux
> Merge branch 'mediatek-drm-fixes-2016-11-11' of https://github.com/ckhu-mediatek/linux.git-tags into drm-fixes
>
> Clearly that branch has never been build-tested by itself. Unfortunately
> the dependency on "HAVE_ARM_SMCCC" caused the driver to not be no longer
> included in x86 allmodconfig builds despite the COMPILE_TEST check,
> so neither David Airlie nor Linus Torvalds caught it before it got merged.
oops bad dependency, I normally have a cross compile on -next, but -fixes I don't always do it, since who would send broken -fixes,
Arnd could you send a git pull with the two reverts, with my Acked-by on it? I won't be in a place to do it for 8-9hrs.
Dave.
>
> Arnd
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
