On 11/16/2016 01:24 AM, Rob Herring wrote:
> On Mon, Nov 14, 2016 at 11:10:35AM +0100, Marek Vasut wrote:
>> Add new DT bindings for new MXSFB driver that is using the
>> OF graph to parse the video output structure instead of
>> hard-coding the display properties into the MXSFB node.
>> The old MXSFB fbdev driver bindings are preserved in the
>> same file in the "Old bindings" section.
>>
>> Signed-off-by: Marek Vasut <marex@xxxxxxx>
>> Cc: Rob Herring <robh@xxxxxxxxxx>
>> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
>> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
>> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> --
>> V2: - Merge the new bindings into mxsfb.txt file instead of keeping
>> them in separate mxsfb-drm.txt file.
>> - Add dedicated compatible for i.MX6SX
>> - Drop all references to DRM/KMS
>> - Repair the required bits in clock node
>> ---
>> .../devicetree/bindings/display/mxsfb.txt | 37 ++++++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
>> index a4431f2..6e92593 100644
>> --- a/Documentation/devicetree/bindings/display/mxsfb.txt
>> +++ b/Documentation/devicetree/bindings/display/mxsfb.txt
>> @@ -1,5 +1,42 @@
>> * Freescale MXS LCD Interface (LCDIF)
>>
>> +New bindings:
>> +=============
>> +Required properties:
>> +- compatible: Should be "fsl,imx23-lcdif" for i.MX23.
>> + Should be "fsl,imx28-lcdif" for i.MX28.
>> + Should be "fsl,imx6sx-lcdif" for i.MX6SX.
>> +- reg: Address and length of the register set for lcdif
>
> s/lcdif/LCDIF/
>
>> +- interrupts: Should contain lcdif interrupts
>
> How many?
>
>> +- clocks: A list of phandle + clock-specifier pairs, one for each
>> + entry in 'clock-names'.
>> +- clock-names: A list of clock names. For MXSFB it should contain:
>> + - "pix" for the MXSFB block clock
>
> MXSFB is not a h/w block. LCDIF is the name.
>
>> + - (MX6SX-only) "axi", "disp_axi" for the bus interface clock
>> +
>> +Required sub-nodes:
>> + - port: The connection to an encoder chip.
>> +
>> +Example:
>> +
>> + lcdif1: lcdif@02220000 {
>
> display-controller@...
>
> Drop the leading 0 too.
Fixed all
>> + compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>
> I'm not sure compatibility with mx28 is appropriate since you have the
> extra clocks. I guess if they don't need to be managed then it's okay.
The other two clock are optional
>> + reg = <0x02220000 0x4000>;
>> + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
>> + <&clks IMX6SX_CLK_LCDIF_APB>,
>> + <&clks IMX6SX_CLK_DISPLAY_AXI>;
>> + clock-names = "pix", "axi", "disp_axi";
>> +
>> + port {
>> + parallel_out: endpoint {
>> + remote-endpoint = <&panel_in_parallel>;
>> + };
>> + };
>> + };
>> +
>> +Old bindings:
>
> s/Old/Deprecated/
Fixed
--
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
