Hello Alex Deucher,
This is a semi-automatic email about new static checker warnings.
The patch 0f12f73c5175: "drm/amd/powerplay/smu7: fix checks in
smu7_get_evv_voltages (v2)" from Nov 9, 2016, leads to the following
Smatch complaint:
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1486 smu7_get_evv_voltages()
warn: variable dereferenced before check 'table_info' (see line 1483)
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c
1482 && !phm_get_sclk_for_voltage_evv(hwmgr,
1483 table_info->vddgfx_lookup_table, vv_id, &sclk)) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1484 if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps,
1485 PHM_PlatformCaps_ClockStretcher)) {
1486 if (table_info == NULL)
^^^^^^^^^^^^^^^^^^
We can't reach this check unless we have already dereferenced
"table_info" so something must be wrong.
1487 return -EINVAL;
1488 sclk_table = table_info->vdd_dep_on_sclk;
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
