Hi Shailendra,
On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote:
> From: "Shailendra Verma" <shailendra.v@xxxxxxxxxxx>
>
> There is possible dereference of NULL pointer if kmalloc fails.
You could add: ... when the function returns. From the patch itself it is
not clear where the problem is.
> So return NULL if kmalloc fails.
>
> Signed-off-by: Shailendra Verma <Shailendra.v@xxxxxxxxxxx>
Acked-by: Liviu Dudau <Liviu.Dudau@xxxxxxx>
Thanks for spotting this!
Liviu
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 82c193e..f769398 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -54,6 +54,9 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane)
> return NULL;
>
> state = kmalloc(sizeof(*state), GFP_KERNEL);
> + if (!state)
> + return NULL;
> +
> if (state) {
> m_state = to_malidp_plane_state(plane->state);
> __drm_atomic_helper_plane_duplicate_state(plane, &state->base);
> --
> 1.7.9.5
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
