On Tue, Nov 08, 2016 at 01:43:25PM +0000, Liviu Dudau wrote:
> In order to support DRM_IOCTL_MODE_OBJ_SETPROPERTY for the rotation property
> we need to have a ->set_property hook defined for the planes. Set the
> plane's ->set_property hook to drm_atomic_helper_plane_set_property()
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@xxxxxxx>
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index bb1c528..8eef9a8 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -89,6 +89,7 @@ void malidp_destroy_plane_state(struct drm_plane *plane,
> static const struct drm_plane_funcs malidp_de_plane_funcs = {
> .update_plane = drm_atomic_helper_update_plane,
> .disable_plane = drm_atomic_helper_disable_plane,
> + .set_property = drm_atomic_helper_plane_set_property,
We discussed this a bit, I think it'd be nice to simply make this the
default for all atomic drivers (and demote all the set_prop helpers from
exported helpers to internal static functions). But can be done as a
cleanup later on, ack for this patch meanwhile.
-Daniel
> .destroy = malidp_de_plane_destroy,
> .reset = drm_atomic_helper_plane_reset,
> .atomic_duplicate_state = malidp_duplicate_plane_state,
> --
> 2.10.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
