I realized that I had not re-sent this after updating from review comments, and adding kerneldoc. The drm/msm bits I can include in my msm-next pull-req for 4.10. Just including them here to show example usage. There will be a minor conflict to resolve around drm_get_format_name(), depending on what the final solution there is. But that should be trivial. If needed I can rebase after that lands. But would be nice if this ended up in drm-next for 4.10 so that I can land the drm/msm bits (and some later patches that use drm_printer to dump SMP state in debugfs and on error irqs) Rob Clark (7): drm: helper macros to print composite types drm: add helper for printing to log or seq_file drm: add helpers to go from plane state to drm_rect drm/atomic: add new drm_debug bit to dump atomic state drm/atomic: add debugfs file to dump out atomic state drm/msm/mdp5: add atomic_print_state support drm/msm: module param to dump state on error irq Documentation/gpu/drm-internals.rst | 17 ++++ drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_atomic.c | 156 ++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_debugfs.c | 9 ++ drivers/gpu/drm/drm_modes.c | 8 +- drivers/gpu/drm/drm_plane_helper.c | 11 +-- drivers/gpu/drm/drm_print.c | 54 +++++++++++ drivers/gpu/drm/drm_rect.c | 11 +-- drivers/gpu/drm/i915/intel_display.c | 10 +- drivers/gpu/drm/i915/intel_sprite.c | 11 +-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_irq.c | 10 ++ drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 11 +++ drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 12 +++ drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 18 +++- drivers/gpu/drm/msm/msm_drv.c | 4 + include/drm/drmP.h | 22 +++++ include/drm/drm_atomic.h | 7 ++ include/drm/drm_connector.h | 13 +++ include/drm/drm_crtc.h | 13 +++ include/drm/drm_plane.h | 36 +++++++ include/drm/drm_print.h | 117 ++++++++++++++++++++++ 21 files changed, 508 insertions(+), 44 deletions(-) create mode 100644 drivers/gpu/drm/drm_print.c create mode 100644 include/drm/drm_print.h -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
