> Subject: Re: [PATCH v5] drm/fsl-dcu: Implement gamma_lut atomic crtc > properties > > On 2016-09-28 01:24, Meng Yi wrote: > > Gamma correction is optional and can be used to adjust the color > > output values to match the gamut of a particular TFT LCD panel > > > > Split the DCU regs into "regs", "palette", "gamma" and "cursor". > > Create a second regmap for gamma memory space using little endian. > > The registers after the first address space are not accessed yet, > > hence new device trees would even work with old kernels. Just new > > kernel need the new format so we can access the separate gamma reg > > space. > > > > Suggested-by: Stefan Agner <stefan@xxxxxxxx> > > Signed-off-by: Meng Yi <meng.yi@xxxxxxx> > > --- > > Changes since V1: > > -created a second regmap for gamma > > -updated the DCU DT binding > > -removed Kconfig for gamma and enable gamma when valid data filled. > > -extended and simplified comment lines. > > --- > > .../devicetree/bindings/display/fsl,dcu.txt | 12 +++++++- > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 33 > ++++++++++++++++++++ > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 35 > +++++++++++++++++++++- > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 7 +++++ > > 4 files changed, 85 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt > > b/Documentation/devicetree/bindings/display/fsl,dcu.txt > > index 63ec2a6..8140b5d 100644 > > --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt > > +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt > > @@ -6,6 +6,12 @@ Required properties: > > * "fsl,vf610-dcu". > > > > - reg: Address and length of the register set for dcu. > > + Must contain four address/length tuples: > > + 1. Register address space > > + 2. Palette/Tile address space > > + 3. Gamma address space > > + 4. Cursor address space > > +- reg-names: Should be "regs", "palette", "gamma" and > "cursor" > > Looks good to me, device tree folks? > > -- > Stefan > Tested-by: Meng Yi <meng.yi@xxxxxxx> On LS1021A-TWR board. Meng _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
