Re: [PATCH] drm: Don't force all planes to be added to the state due to zpos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 26, 2016 at 04:09:00PM +0200, Benjamin Gaignard wrote:
> I have just tested it on my board, no regression :-)
> 
> Acked-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> 
> 2016-10-25 22:53 GMT+02:00 Sean Paul <seanpaul@xxxxxxxxxxxx>:
> > On Tue, Oct 25, 2016 at 10:43 AM, Ville Syrjälä
> > <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> >> On Mon, Oct 10, 2016 at 03:19:47PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> >>> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> >>>
> >>> We don't want all planes to be added to the state whenever a
> >>> plane with fixed zpos gets enabled/disabled. This is true
> >>> especially for eg. cursor planes on i915, as we want cursor
> >>> updates to go through w/o throttling. Same holds for drivers
> >>> that don't support zpos at all (i915 actually falls into this
> >>> category right now since we've not yet added zpos support).
> >>>
> >>> Allow drivers more freedom by letting them deal with zpos
> >>> themselves instead of doing it in drm_atomic_helper_check_planes()
> >>> unconditionally. Easiest solution seems to be to move the call
> >>> up to drm_atomic_helper_check(). But as some drivers might want
> >>> to use that function without the zpos handling, let's provide
> >>> two variants: the normal one, and one that deals with zpos.
> >>>
> >>> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> >>> Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> >>> Cc: Vincent Abriou <vincent.abriou@xxxxxx>
> >>> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> >>> Cc: Inki Dae <inki.dae@xxxxxxxxxxx>
> >>> Cc: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> >>> Cc: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>
> >>> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> >>> Cc: Lyude <cpaul@xxxxxxxxxx>
> >>> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> >>> Cc: stable@xxxxxxxxxxxxxxx
> >>> Fixes: 44d1240d006c ("drm: add generic zpos property")
> >>> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> >>
> >> Ping. Can I get some buy-in from the relevant folks?
> >>
> >
> > Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
> >
> > FWIW :)

Applied to drm-misc-fixes, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux