Re: [RFC PATCH v2 9/9] drm: mali-dp: Add writeback out-fence support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2016-10-26 Brian Starkey <brian.starkey@xxxxxxx>:

> If userspace has asked for an out-fence for the writeback, we add a
> fence to malidp_mw_job, to be signaled when the writeback job has
> completed.
> 
> Signed-off-by: Brian Starkey <brian.starkey@xxxxxxx>
> ---
>  drivers/gpu/drm/arm/malidp_hw.c |    5 ++++-
>  drivers/gpu/drm/arm/malidp_mw.c |   18 +++++++++++++++++-
>  drivers/gpu/drm/arm/malidp_mw.h |    3 +++
>  3 files changed, 24 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c
> index 1689547..3032226 100644
> --- a/drivers/gpu/drm/arm/malidp_hw.c
> +++ b/drivers/gpu/drm/arm/malidp_hw.c
> @@ -707,8 +707,11 @@ static irqreturn_t malidp_se_irq(int irq, void *arg)
>  		unsigned long irqflags;
>  		/*
>  		 * We can't unreference the framebuffer here, so we queue it
> -		 * up on our threaded handler.
> +		 * up on our threaded handler. However, signal the fence
> +		 * as soon as possible
>  		 */
> +		malidp_mw_job_signal(drm, malidp->current_mw, 0);

Drivers should not deal with fences directly. We need some sort of 
drm_writeback_finished() that will do the signalling for you.

Gustavo

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux