On Thu, Sep 29, 2016 at 10:48:38PM +0200, Stefan Christ wrote:
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: Christian König <christian.koenig@xxxxxxx>
> Signed-off-by: Stefan Christ <contact@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> index 9191467..6b80982 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> @@ -50,14 +50,10 @@ struct amdgpu_fbdev {
>
> static struct fb_ops amdgpufb_ops = {
> .owner = THIS_MODULE,
> - .fb_check_var = drm_fb_helper_check_var,
> - .fb_set_par = drm_fb_helper_set_par,
> + DRM_FB_HELPER_DEFAULT_OPS,
> .fb_fillrect = drm_fb_helper_cfb_fillrect,
> .fb_copyarea = drm_fb_helper_cfb_copyarea,
> .fb_imageblit = drm_fb_helper_cfb_imageblit,
> - .fb_pan_display = drm_fb_helper_pan_display,
> - .fb_blank = drm_fb_helper_blank,
> - .fb_setcmap = drm_fb_helper_setcmap,
> .fb_debug_enter = drm_fb_helper_debug_enter,
> .fb_debug_leave = drm_fb_helper_debug_leave,
Ok, wanted to start vacuuming stuff up, but then realized that this
doesn't share the fb_fillrect, fb_copyarea, fb_imageblit and
fb_debug_enter/leave funcs. Not sharing fb_mmap makes sense, because that
must be special. But all the others can be shared. Any reasons for not
doing so?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
