Re: [PATCH] drm/amdgpu: fix a vm_flush fence leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 24, 2016 at 5:07 AM, Christian König
<deathsimple@xxxxxxxxxxx> wrote:
> Am 24.10.2016 um 04:32 schrieb zhoucm1:
>>
>>
>>
>> On 2016年10月24日 02:31, Grazvydas Ignotas wrote:
>>>
>>> Looks like .last_flush reference is left at teardown.
>>> Leak reported by CONFIG_SLUB_DEBUG.
>>>
>>> Fixes: 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")
>>> Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx>
>>
>> Reviewed-by: Chunming Zhou <david1.zhou@xxxxxxx>
>
>
> Reviewed-by: Christian König <christian.koenig@xxxxxxx>.
>
>>> ---
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> index ded57dd..d6c2839 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> @@ -1774,5 +1774,6 @@ void amdgpu_vm_manager_fini(struct amdgpu_device
>>> *adev)
>>>           fence_put(adev->vm_manager.ids[i].first);
>>> amdgpu_sync_free(&adev->vm_manager.ids[i].active);
>>>           fence_put(id->flushed_updates);
>>> +        fence_put(id->last_flush);
>>>       }
>>>   }

Applied.  Thanks!

Alex
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux