On 23 October 2016 at 01:32, Karol Herbst <karolherbst@xxxxxxxxx> wrote:
I think it would be better to squash those commits:
1. for the includes
2. for static declerations
OK, I have resent new patch that squash those commits.
> ______________________________2016-10-22 11:41 GMT+02:00 Baoyou Xie <baoyou.xie@xxxxxxxxxx>:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h.
> So this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> ---
> drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/ nvkm/core/firmware.c
> index 34ecd4a..058ff46 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
> @@ -20,6 +20,7 @@
> * DEALINGS IN THE SOFTWARE.
> */
> #include <core/device.h>
> +#include <core/firmware.h>
>
> /**
> * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory
> --
> 2.7.4
>
_________________
> Nouveau mailing list
> Nouveau@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
