On Wed, Oct 19, 2016 at 11:52:15AM +0300, Laurent Pinchart wrote: > Hi Russell, > > On Wednesday 19 Oct 2016 09:16:30 Russell King - ARM Linux wrote: > > On Wed, Oct 19, 2016 at 10:54:06AM +0300, Laurent Pinchart wrote: > > > On Wednesday 19 Oct 2016 00:33:54 Jyri Sarha wrote: > > >> Remove obsolete drm_connector_register() call from tda998x_bind(). All > > >> connectors are registered when drm_dev_register() is called by the > > >> master drm_device driver. > > >> > > >> Signed-off-by: Jyri Sarha <jsarha@xxxxxx> > > > > > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > > > By the way, any chance you would plan porting the driver to drm_bridge ? > > > :-) > > > > What's the point? > > Avoiding code duplication. We currently have three APIs to handle external > encoders (drm encoder slave, drm bridge and the component-based method used by > tda998x only), which requires display drivers that want to support multiple > external encoders to use up to three APIs. tda998x doesn't use the encoder slave anymore. You somehow list component- based as a third alternative - it isn't, that's the native DRM non-bridge method. In any case, I don't agree with converting it to a DRM bridge - that will mean that we have to split the driver into two pieces, the bridge part handling the mode set specifics, and a connector/encoder part which handles the detection/edid stuff. We might as well keep the whole thing as the classical connector/encoder rather than introducing this additional layer of complexity. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
