Am Mittwoch, den 19.10.2016, 10:58 +0300 schrieb Ville Syrjälä: > On Tue, Oct 18, 2016 at 06:07:49PM +0200, Philipp Zabel wrote: > > Odd x/y offsets are not allowed for chroma subsampled planar YUV > > formats. > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/imx/ipuv3-plane.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c > > index 5c34299..3a03fd8 100644 > > --- a/drivers/gpu/drm/imx/ipuv3-plane.c > > +++ b/drivers/gpu/drm/imx/ipuv3-plane.c > > @@ -259,6 +259,7 @@ static int ipu_plane_atomic_check(struct drm_plane *plane, > > struct drm_framebuffer *fb = state->fb; > > struct drm_framebuffer *old_fb = old_state->fb; > > unsigned long eba, ubo, vbo, old_ubo, old_vbo; > > + int hsub, vsub; > > > > /* Ok to disable */ > > if (!fb) > > @@ -372,6 +373,13 @@ static int ipu_plane_atomic_check(struct drm_plane *plane, > > > > if (old_fb && old_fb->pitches[1] != fb->pitches[1]) > > crtc_state->mode_changed = true; > > + > > + /* x and y offsets must be even in case of chroma subsampling */ > > + hsub = drm_format_horz_chroma_subsampling(fb->pixel_format); > > + vsub = drm_format_vert_chroma_subsampling(fb->pixel_format); > > + if (((state->src_x >> 16) & (hsub - 1)) || > > + ((state->src_y >> 16) & (vsub - 1))) > > BTW you should use clipped coordinates all over instead of the raw > user coordinates. I see you're rejecting negative crtc user coordinates > and whanot so I guess it sort of works, but that's not how it's supposed > to be done. drm_plane_helper_check_state() should give you most of > what's needed. Thank you for the pointer, I'll add a patch to use drm_plane_helper_check_state. regards Philipp _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
