Comment # 4
on bug 98005
from Boyuan Zhang
(In reply to Andy Furniss from comment #3) > (In reply to Boyuan Zhang from comment #2) > > Hi Andy, > > > > The corruption/out of order issue has been reproduced locally. Root cause > > and fix can be found at > > https://lists.freedesktop.org/archives/mesa-dev/2016-October/132268.html > > > > Please give a try. > > > > Regards, > > Boyuan > > Thanks, that does fix the out of order and corruption. > > As you explained in the thread above, dual instance bitrate control is a > separate issue, but this patch does change behavior a bit. > > cbr is unaffected by patch and could be seen as OK (unless I find a better > test to break it). md5sums may vary but the bitrate/file size is only > different by a tiny amount and visually things seem OK. > > vbr is different, before patch it may be OK, but there was a chance of some > files being less that half size/rate than they should. > > With the patch it seems that they are all now less than half rate. So at > least it's consistent (md5sums do still vary). > > Will test more tomorrow as it's late here. Hi Andy, Regarding to the bitrate/file size issue, I didn't see it with my local tests. For example, "vaapih264enc rate-control=cbr bitrate=15000" and "vaapih264enc rate-control=vbr bitrate=21428" will give me almost same output file size, which is expected results since 21428*70%=15000. Maybe the command/clip we tested are different. Can you share the command & clip where you saw vbr got half of the expected value please? Regards, Boyuan
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
